Erlang/OTP Forums

Author Message

<  Yaws mailing list  ~  yaws_api:pre_ssi_files

Guest
Posted: Fri Mar 07, 2008 9:29 am Reply with quote
Guest
Hi!
Juste a little question about the function 'yaws_api:pre_ssi_files'.
Why two 'bre' and a 'div' are appended to the 'pre' like below ?
<br><br> <div class="box"><pre>[..]</pre></div>

/Greg

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Erlyaws-list mailing list
Erlyaws-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/erlyaws-list
Post recived from mailinglist
Guest
Posted: Fri Mar 07, 2008 12:08 pm Reply with quote
Guest
Greg Burri wrote:
> Hi!
> Juste a little question about the function 'yaws_api:pre_ssi_files'.
> Why two 'bre' and a 'div' are appended to the 'pre' like below ?
> <br><br> <div class="box"><pre>[..]</pre></div>
>

Uhh that looks disgusting. Should be removed.

Should obviously look like:


pre_ssi_string(Str, Class) ->
{html, ["\n<div class=\"", Class, "\"> <pre>\n",
htmlize_l(Str),
"\n</pre></div>"\n]}.


/klacke

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Erlyaws-list mailing list
Erlyaws-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/erlyaws-list
Post recived from mailinglist
Guest
Posted: Fri Mar 07, 2008 2:38 pm Reply with quote
Guest
Thanks for your answer.
Why don't let the programmer decide to put or not the div ?

/Greg

On Fri, Mar 7, 2008 at 1:00 PM, Claes Wikstr
Guest
Posted: Fri Mar 07, 2008 8:29 pm Reply with quote
Guest
Greg Burri wrote:
> Thanks for your answer.
> Why don't let the programmer decide to put or not the div ?

actually this function shouldn't even be in yaws_api.erl
It should go away since it does nothing interesting at all.

My guess is that it's there since I once needed it for the yaws
home page itself and found no better place to put it - sigh

As I said - this should be cleaned up.

/klacke

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Erlyaws-list mailing list
Erlyaws-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/erlyaws-list
Post recived from mailinglist

Display posts from previous:  

All times are GMT
Page 1 of 1
This forum is locked: you cannot post, reply to, or edit topics.

Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You can attach files in this forum
You can download files in this forum